Log error when ad click fails

webcontroller/ad_click.go

@@ -27,7 +27,7 @@ func (wc *WebController) serveAdClick(w http.ResponseWriter, r *http.Request, p
 
 	// Log a view on the file
 	if err := api.PostFileView(p.ByName("id"), wc.viewTokenOrBust()); err != nil {
-		log.Warn("Failed to log view")
+		log.Error("Failed to log view: %s", err)
 	}
 }
 

webcontroller/admin_panel.go

@@ -4,7 +4,6 @@ import (
 	"fmt"
 	"html/template"
 	"net/http"
-	"strings"
 
 	"fornaxian.com/pixeldrain-web/pixelapi"
 	"github.com/Fornaxian/log"
@@ -65,9 +64,6 @@ func (wc *WebController) adminGlobalsForm(td *TemplateData, r *http.Request) (f
 	if f.ReadInput(r) {
 		var successfulUpdates = 0
 		for k, v := range f.Fields {
-			// Remove carriage returns from input
-			v.EnteredValue = strings.ReplaceAll(v.EnteredValue, "\r", "")
-
 			if v.EnteredValue == globalsMap[v.Name] {
 				continue // Change changes, no need to update
 			}

webcontroller/forms.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"html/template"
 	"net/http"
+	"strings"
 )
 
 // Form is a form which can be rendered in HTML and submitted
@@ -99,7 +100,8 @@ func (f *Form) ReadInput(r *http.Request) (success bool) {
 	f.Submitted = true
 
 	for i, field := range f.Fields {
-		field.EnteredValue = r.FormValue(field.Name)
+		// Remove carriage returns
+		field.EnteredValue = strings.ReplaceAll(r.FormValue(field.Name), "\r", "")
 
 		if field.DefaultValue == "" {
 			field.DefaultValue = field.EnteredValue