From daad1943040f59d6def44305b37c8b3571009369 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Matczuk?= Date: Fri, 25 May 2018 11:00:45 +0200 Subject: [PATCH] reflectx: fixes to items reported by megacheck --- reflectx/reflect.go | 4 +--- reflectx/reflect_test.go | 3 --- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/reflectx/reflect.go b/reflectx/reflect.go index 73c21eb..458021d 100644 --- a/reflectx/reflect.go +++ b/reflectx/reflect.go @@ -269,9 +269,7 @@ type typeQueue struct { // A copying append that creates a new slice each time. func apnd(is []int, i int) []int { x := make([]int, len(is)+1) - for p, n := range is { - x[p] = n - } + copy(x, is) x[len(x)-1] = i return x } diff --git a/reflectx/reflect_test.go b/reflectx/reflect_test.go index 22f57fd..d14d023 100644 --- a/reflectx/reflect_test.go +++ b/reflectx/reflect_test.go @@ -603,7 +603,6 @@ func TestMapperMethodsByName(t *testing.T) { A0 *B `db:"A0"` B `db:"A1"` A2 int - a3 int } val := &A{ @@ -811,8 +810,6 @@ func TestMustBe(t *testing.T) { t.Error("expected panic with *reflect.ValueError") return } - if valueErr.Method != "github.com/jmoiron/sqlx/reflectx.TestMustBe" { - } if valueErr.Kind != reflect.String { t.Errorf("unexpected Kind: %s", valueErr.Kind) }